Conversation
Merge pull request #2399 from firebase/next
#2402) * fix(firestore-send-email): add types and attempt to extract message ID * feat(firestore-send-email): patch nodemailer-sendgrid * test(firestore-send-email): add tests for nodemailer sendgrid patch * feat(firestore-send-email): explicitly handle sendgrid keys * fix(firestore-send-email): better extract message id * feat(firestore-send-email): return sendgrid queue id and message id * chore(firestore-send-email): bump versions etc * test(firestore-send-email): update tests * refactor(firestore-send-email): extract sendgrid transport types * chore(firestore-send-email): restore code comments * chore(firestore-send-email): improve types * chore(firestore-send-email): add extended options type * chore(firestore-send-email): add JSDoc comments * docs(firestore-send-email): update sendgrid docs
* feat(firestore-bigquery-export): add bigquery dataset locations * chore(firestore-bigquery-export): remove duplicate bigquery dataset locations * chore: bump firestore-bigquery-export version * chore: run formatter
* feat(import-script): handle not finding collection * fix(import-script): await runSingleThread * refactor(import-script): extract variable to avoid calculating twice
CorieW
approved these changes
May 12, 2025
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
cabljac
changed the title
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will trigger the release for firestore-send-email