Conversation
Merge pull request #2434 from firebase/next
There was a problem hiding this comment.
Pull Request Overview
This PR releases version 0.2.4 of the Firestore Send Email extension by fixing the TTL “week” calculation, adding support for custom email headers, and updating documentation and changelog.
- Fixed
weekinterval ingetExpireAtto multiply days by 7 and added a default error case. - Added
headersfield to the email delivery options. - Bumped extension version and updated docs (README, PREINSTALL) and CHANGELOG.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| functions/src/index.ts | Corrected TTL “week” logic, added default case, and support for headers |
| extension.yaml | Version bumped from 0.2.3 to 0.2.4 |
| README.md | Added “Using custom headers” section with JSON example |
| PREINSTALL.md | Added “Using custom headers” section with JSON example |
| CHANGELOG.md | Added v0.2.4 entries for header support and TTL fix |
Comments suppressed due to low confidence (3)
firestore-send-email/functions/src/index.ts:176
- New
headerssupport was added but no tests appear to cover custom headers. Consider adding unit or integration tests to verify headers are passed correctly.
headers: payload?.headers,
firestore-send-email/README.md:44
- The example JSON has a trailing comma after the last property, which isn’t valid JSON. Removing the trailing comma will avoid confusion for users.
"X-Another-Header": "AnotherValue",
firestore-send-email/PREINSTALL.md:36
- The example JSON has a trailing comma after the last header entry, which is not valid JSON. Please remove the trailing comma.
"X-Another-Header": "AnotherValue",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.