Skip to content

chore: remove temporary Dart console warning#10584

Open
demolaf wants to merge 2 commits into
mainfrom
dart-console-support
Open

chore: remove temporary Dart console warning#10584
demolaf wants to merge 2 commits into
mainfrom
dart-console-support

Conversation

@demolaf
Copy link
Copy Markdown
Member

@demolaf demolaf commented Jun 2, 2026

The Firebase Console now supports Dart functions, so the temporary warning directing users to the Cloud Console is no longer needed.

@demolaf demolaf requested a review from ajperel June 2, 2026 09:43
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the temporary Dart runtime check and its associated warning message during the functions release process. The reviewer correctly noted that removing this check leaves the import of runtimeIsLanguage unused, which should be cleaned up.

I am having trouble creating individual review comments. Click here to see my feedback.

src/deploy/functions/release/index.ts (118-127)

medium

Since the Dart runtime check has been removed, the import of runtimeIsLanguage on line 20 is now unused and should be removed.

@demolaf demolaf requested a review from cabljac June 2, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants