fix(hosting): route Cloud Run rewrites to local functions emulator#10588
Open
demolaf wants to merge 2 commits into
Open
fix(hosting): route Cloud Run rewrites to local functions emulator#10588demolaf wants to merge 2 commits into
demolaf wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for routing Cloud Run rewrites to the local functions emulator when 'functions' is specified in the targets and the emulator is running. The review feedback suggests optimizing the implementation by replacing lodash dependencies (includes and cloneDeep) with native TypeScript features, such as optional chaining with Array.prototype.includes and standard object spreading, which allows for the removal of the external lodash imports.
demolaf
force-pushed
the
fix/cloud-run-proxy-emulator
branch
from
6095037 to
1dff63b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Firebase Hosting rewrites with
"run"format (required for Dart/Cloud Run functions),the hosting emulator always hit the live Cloud Run API to resolve the service URL — even when the
functions emulator was running locally. This caused an error like:
Fix
Add emulator detection to
cloudRunProxy.ts, mirroring the existing logic infunctionsProxy.ts.When
targetsincludes"functions"and the functions emulator is running, route directly to thelocal emulator URL instead of calling the Cloud Run API.
Related firebase/firebase-functions-dart#200