Stable builds

[AustinBenoit]

Description

Provide details of the change, and generalize the change in the PR title above.

---

Testing

Describe how you've tested these changes.

---

Type of Change

Place an x the applicable box:

• Bug fix. Add the issue # below if applicable.
• New feature. A non-breaking change which adds functionality.
• Other, such as a build process or documentation change.

---

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the reliability of build status reporting by improving how build artifacts are processed and how integration test failures are identified within GitHub Action logs. The changes ensure more accurate detection of build failures, especially in cases where artifacts expire or log formats vary, leading to more stable and trustworthy build status indications.

Highlights

• Improved Artifact Handling: The logic for processing build artifacts has been refined to ensure artifact_contents is explicitly initialized, preventing potential issues if the artifact is not found or downloaded.
• Enhanced Log Parsing for Integration Test Failures: The regular expression used to detect integration test failures in GitHub logs has been updated to be more robust, accommodating both [error] and ::error:: prefixes, as well as \n or %0A line endings.
• Explicit Failure Reporting for Unmatched Logs: A new condition was added to explicitly mark a build as failed with an 'Unknown Error' if the expected integration test failure string cannot be found in the logs when artifacts are unavailable. This ensures that runs are not incorrectly reported as successful due to log parsing issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/integration_tests.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves the stability of the build reporting script. The main change is to correctly handle cases where test result artifacts are missing or expired. Instead of implicitly marking the run as successful, it now correctly reports a failure, which makes the reporting more reliable. The regular expression for parsing failure logs has also been improved to be more robust. I've included a suggestion to optimize the code that finds build artifacts, making it more efficient and readable.

[gemini-code-assist]

To improve efficiency and readability, you can find the artifact and its ID in a single pass over the artifacts list instead of iterating multiple times. Using next() with a generator expression is a more Pythonic way to achieve this.

Suggested change

	if 'build_and_test_results' in [a['name'] for a in artifacts]:
	artifact_id = [a['id'] for a in artifacts if a['name'] == 'build_and_test_results'][0]
	artifact_contents = firebase_github.download_artifact(FLAGS.token, artifact_id)
	build_results_artifact = next((a for a in artifacts if a['name'] == 'build_and_test_results'), None)
	if build_results_artifact:
	artifact_contents = firebase_github.download_artifact(FLAGS.token, build_results_artifact['id'])