Fix Internal, Functions and FirebaseAI asmdefs to match supported platforms#1469
Open
EllieTellie wants to merge 1 commit into
Open
Fix Internal, Functions and FirebaseAI asmdefs to match supported platforms#1469EllieTellie wants to merge 1 commit into
EllieTellie wants to merge 1 commit into
Conversation
…dll.meta platform settings Firebase won't build on unsupported platforms otherwise.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the assembly definition files (.asmdef) for Firebase.App.Internal, Firebase.FirebaseAI, and Firebase.Functions to explicitly specify the supported target platforms in includePlatforms rather than leaving it empty. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Firebase won't build on unsupported platforms such as Windows Store or platforms that are not supported by Firebase.App.dll.
Recent asmdefs for Internal, Functions and FirebaseAI do not specify included platforms and compile on all platforms. They should include the same platforms that Firebase.App.dll supports because Firebase.App.dll/Firebase.Platform.dll is referenced as precompiledReferences inside the asmdef. This will trigger a compile error CS0246 as it cannot reference Firebase.App.
Testing
Reproduction Steps
Install Firebase 13.11.0 or newer. Prior versions not affected, introduced in #1439.
Build for Windows Store (UWP / WSAPlayer) and it will fail to compile when you make runtime builds. Note: it compiles in editor because Firebase.App.dll is included in Editor.
Once I made these changes to the package it compiled when building for Windows Store (UWP / WSAPlayer).
Type of Change