-
Notifications
You must be signed in to change notification settings - Fork 651
refactor(py): move session/chat into blocks and remove public API #4321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @huangjeff5, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the Python Genkit library by consolidating session and chat functionalities under the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a significant refactoring that moves the session and chat management logic into the genkit.blocks package and removes the public API surface from the top-level genkit.ai module. This is a good architectural improvement that helps to better organize the code. A key part of this change is the introduction of a new genkit.blocks.interfaces module, which defines shared protocols like SessionLike and GenkitLike to break circular dependencies. The implementations of chat.send() and chat.send_stream() have also been simplified. Additionally, several demo applications have been removed, presumably because they relied on the now-internalized public APIs.
My review has identified one critical issue: a syntax error in py/packages/genkit/src/genkit/ai/_registry.py due to incorrect indentation after removing a TYPE_CHECKING block. I've also provided a medium-severity suggestion to restore the detailed docstrings for the send and send_stream methods in chat.py, as the examples and parameter explanations were valuable for users.
Overall, the refactoring is well done and improves the codebase structure, pending the fix for the critical syntax error.
Consolidate session/chat under blocks, drop ai-level session/chat surfaces, and
introduce shared interfaces to avoid type-only import cycles.