Conversation
chore: sync main into develop
javier-alvarez
pushed a commit
that referenced
this pull request
May 4, 2026
Addresses the deferred items from the code review (review of commit b84c3bc). After this commit, only FF-2 (file an upstream issue) and FF-5 (per-doc correlation_id at ingest time) remain as follow-ups. FF-6 / Review #6 — real-time per-file ingest output: ``_run_ingest`` now walks the drop folder itself and calls ``agent.ingest_one`` per file, streaming ``[N/total] starting ...`` and the terminal ``[status]`` line as each file completes. Review #6 — noisy-logger override env var FIREFLY_AGENTIC_VERBOSE_LOGGERS. FF-1 — ``--force-clean`` actually wipes ./kg now (with TTY confirmation prompt; CI / scripts skip the prompt because the flag itself is consent). Review #8 — Retry-After "first match wins" assumption documented. Review #9 — idempotency-signature asymmetry (otlp endpoint vs azure conn string) documented in configure_exporters docstring. Review #10 — _ENCODING tri-state cleanup (replaced object|None hack with a clean (loaded, encoder) tuple cache). Review #12 — rerank_fallback label spec update. Full sweep: 1220 passed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ancongui
added a commit
that referenced
this pull request
May 31, 2026
fix: use pyright basic mode for CI stability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from standard to basic typeCheckingMode. Standard mode reports false positives on async context managers and dynamic protocol patterns. Basic mode catches real bugs without blocking CI.