Conversation
chore: sync main into develop
- Fix 40 pyright errors across 19 source files:
- Add type: ignore[import-not-found] for optional deps (fastapi, aiokafka,
aio_pika, asyncpg, motor, httpx, opentelemetry)
- Fix ModelSettings typing in agents/base.py using cast
- Fix date vs datetime type mismatch in observability/quota.py
- Fix stream typing with cast/type-ignore in streaming.py, websocket.py
- Fix dynamic attribute access in router.py, toolkit.py, steps.py
- Fix object -> Any typing in logging.py, encryption.py
- Fix None guard in reasoning/base.py
- Move importlib.util import to top of file in http.py
- Fix 16 test failures:
- Add autouse fixtures for mock motor/asyncpg modules in DB store tests
- Convert sync wrapper tests to async (asyncio.run incompatible with
pytest-asyncio event loop)
- Fix HttpTool tests to use urllib fallback path (use_pool=False)
Verified: pyright 0 errors, ruff 0 errors, 819 tests passing.
ancongui
added a commit
that referenced
this pull request
May 31, 2026
fix: resolve all pyright type errors and fix failing tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pyright src/— 0 errors, 0 warningsruff check src/— all checks passedruff format --check src/— 133 files formattedpytest tests/— 819 passed, 1 skipped