refactor(pipeline): collapse invoke() to single return path#240
Merged
miguelgfierro merged 1 commit intoMay 28, 2026
Merged
Conversation
Replace 7 _finalize_run call sites in StatePipeline.invoke with a single try/finally that ends the pipeline span and emits on_pipeline_complete once. Remove the _finalize_run helper. Behavior unchanged; net -32 LOC.
This was referenced May 28, 2026
ancongui
pushed a commit
that referenced
this pull request
May 31, 2026
…-invoke-single-return refactor(pipeline): collapse invoke() to single return path
ancongui
pushed a commit
that referenced
this pull request
May 31, 2026
After the try/finally introduced in #240, pyright could not narrow result: StatePipelineResult | None to StatePipelineResult at the return statement (a finally block can reassign, so the narrowing must be local). Add an explicit assert before return — same runtime guarantee, makes the non-None invariant visible to pyright.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses finding #5 from the simplifier review of #232.
StatePipeline.invokehad sevenreturn await self._finalize_run(StatePipelineResult(...), pipeline_span, pipeline_start_time, run_id)call sites — each passing the same three captured locals. This collapses them into onetry/finally:result = StatePipelineResult(...)andbreaks.finallyblock ends the pipeline span and emitson_pipeline_completeexactly once._finalize_runhelper removed.Net −32 LOC in
state_pipeline.py(144 insertions, 176 deletions).Behavior
Unchanged:
on_pipeline_startis emitted).on_pipeline_completewith the correctsuccessvalue.Verification
pytest tests/unit/pipeline/→ 142 passed.ruff check+ruff format --checkclean.