fix(example): software-factory pipeline imports PipelineEngine (post-#255)#256
Merged
miguelgfierro merged 1 commit intoMay 28, 2026
Conversation
Layer 8 (#255) deleted StatePipeline but I missed the import + return type in examples/software_factory/pipeline.py. CI on #232 fails to collect tests/examples/software_factory/test_pipeline.py with: ImportError: cannot import name 'StatePipeline' from 'fireflyframework_agentic.pipeline' Fix: import PipelineEngine instead and drop the now-unnecessary cast. PipelineBuilder.build() returns PipelineEngine directly after Layer 8. Test passes locally.
ancongui
pushed a commit
that referenced
this pull request
May 31, 2026
…-example fix(example): software-factory pipeline imports PipelineEngine (post-#255)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer 8 (#255) deleted
StatePipelinebut the import + return type inexamples/software_factory/pipeline.pystill referenced it. CI on #232 fails to collecttests/examples/software_factory/test_pipeline.py:Fix: import
PipelineEngineinstead and drop the now-unnecessarycast—PipelineBuilder.build()returnsPipelineEnginedirectly after Layer 8.Test passes locally.