This repository was archived by the owner on Sep 11, 2018. It is now read-only.
Adding dacver and psgver arguments to smps2asm.#2
Open
MainMemory wants to merge 2 commits intoflamewing:masterfrom
Open
Adding dacver and psgver arguments to smps2asm.#2MainMemory wants to merge 2 commits intoflamewing:masterfrom
MainMemory wants to merge 2 commits intoflamewing:masterfrom
Conversation
|
IMO psgver shouldn't affect nMaxPSG, since your intention was (probably) to support S3K DACs/PSGs in S1 SMPS files. |
Author
|
But if you converted the song to S3K and then to ASM, wouldn't it use those different values for nMaxPSG? |
|
If you convert to S3K-SMPS, then the "format version" (sonicver) is S3K, no matter what dacver/psgver. Example: You convert a song from S1 to S3K-SMPS while keeping the DAC/PSG instruments from S1. That makes sonicver=3, dacver/psgver = 1. But the highest PSG note will be the S3K one (nMaxPSG1/2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.