feat(kotlin): kapt opt-out and default-stage dedup across modules (#921)#922
Open
dieppa wants to merge 1 commit into
Open
feat(kotlin): kapt opt-out and default-stage dedup across modules (#921)#922dieppa wants to merge 1 commit into
dieppa wants to merge 1 commit into
Conversation
* feat(kotlin): kapt opt-out and default-stage dedup across modules Address the two Kotlin-support follow-ups captured after the #918 fix in KOTLIN_SUPPORT_FOLLOWUPS.md. * Kapt auto-apply opt-out via `flamingock.autoApplyKapt` Gradle property (default true; opt out with literal case-insensitive `false`). Gradle property, not DSL: the `plugins { }` block evaluates before `flamingock { }`, so a DSL setter would fire too late. * Mixed Java+Kotlin modules no longer produce duplicate default-stage entries in the composite pipeline. `MetadataLoader.CompositePipelineBuilder` now applies the same id-deduplicated same-name collapse to default stages that legacy stages already used. Identity-field mismatches still WARN for default stages so genuine misconfigurations stay visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the two Kotlin-support follow-ups captured after the #918
fix in KOTLIN_SUPPORT_FOLLOWUPS.md.
Kapt auto-apply opt-out via
flamingock.autoApplyKaptGradleproperty (default true; opt out with literal case-insensitive
false). Gradle property, not DSL: theplugins { }blockevaluates before
flamingock { }, so a DSL setter would firetoo late.
Mixed Java+Kotlin modules no longer produce duplicate
default-stage entries in the composite pipeline.
MetadataLoader.CompositePipelineBuildernow applies the sameid-deduplicated same-name collapse to default stages that
legacy stages already used. Identity-field mismatches still
WARN for default stages so genuine misconfigurations stay
visible.