Skip to content

Fix MSVC compilation error in types.hpp #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Snesnopic wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix MSVC compilation error in types.hpp #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c60aea4
Check for _MSVC_LANG version instead of just __cplusplus
Snesnopic May 20, 2026
283f4ab
When definind __x86_64__, properly check that we are on x64
Snesnopic May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/types.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ limitations under the License.
typedef unsigned __int64 uint64_t;
typedef __int64 int64_t;
#else
#if __cplusplus >= 201103L
#if (__cplusplus >= 201103L) || (defined(_MSVC_LANG) && _MSVC_LANG >= 201103L)
// C++11 or later
#include <cstdint>
#include <cstddef>
Expand All @@ -45,10 +45,10 @@ limitations under the License.
#define snprintf _snprintf
#endif

#if !defined(__x86_64__)
#if defined(_M_X64) && !defined(__x86_64__)
#define __x86_64__ _M_X64
#endif
#if !defined(__i386__)
#if defined(_M_IX86) && !defined(__i386__)
#define __i386__ _M_IX86
#endif
#endif
Expand Down Expand Up @@ -206,7 +206,7 @@ limitations under the License.

namespace kanzi
{
#if __cplusplus >= 201703L
#if (__cplusplus >= 201703L) || (defined(_MSVC_LANG) && _MSVC_LANG >= 201703L)
using byte = std::byte;
#else
typedef uint8_t byte;
Expand Down