chore: add color-scheme property to root.less#4357
Open
zDaleZ wants to merge 1 commit intoflarum:2.xfrom
Open
Conversation
This property helps browser to understand which color scheme we're using, and it can make adjustments to the user interface, such as scrollbars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This property helps browser to understand which color scheme we're using, and it can make adjustments to the user interface, such as scrollbars and form controls(checkbox). We're able to change most of things, but there're actually some things controlled by browser, which can't be controlled by us. Besides, if a user is using Chrome's Auto Dark Theme, set this property can turn off color overrides in this case. Chrome's Auto Dark Theme sometimes inverts avatars' color.
Changes proposed in this pull request:
The whole UI.
Reviewers should focus on:
Scrollbar, checkbox in dark mode, etc.
Screenshot
N/A
Necessity
Confirmed
composer test).