[1.x] Fix abandoned-extensions sync never being scheduled#4706
Merged
Conversation
The sync command was registered onto `flarum.console.scheduled` in ExtensionServiceProvider::boot(). ConsoleServiceProvider consumes that array in its own boot() and is registered first, so the entry was appended too late and the task was never scheduled. Move the command and schedule registration into register() so it is present when the schedule is built. Fixes #4705
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4705.
ExtensionServiceProviderregistered theextensions:sync-abandonedcommand and its weekly schedule ontoflarum.console.scheduledinsideboot().ConsoleServiceProvider::boot()is what consumes that array to build the Laravel schedule, and it is registered beforeExtensionServiceProvider, so the entry was appended too late and the task was never scheduled. The weekly sync therefore never ran and the abandoned-extensions list was never refreshed.This moves the
flarum.console.commandsandflarum.console.scheduledregistrations intoregister(), which completes for all providers before anyboot(), so the entry is present when the schedule is built. TheDisablingevent listener stays inboot()as it depends on the dispatcher.Adds an integration test asserting
extensions:sync-abandonedappears inschedule:list. The test fails on the current code and passes with the fix.A 2.x port will follow.