[2.x] test: cover DiscussionPage post-stream seeding (#4703 follow-up)#4708
Merged
Conversation
Locks in the behaviour of #4703 and guards against reintroducing #4137: - A contiguous preloaded seed produces a visible window covering exactly those posts, with no gaps (no perpetually-loading post). - An empty seed leaves the window at the baseline, so in-app navigation (where the API show response embeds no posts) is unchanged. - preloadedNearPage() returns only the longest contiguous run of store-loaded posts, dropping stray non-contiguous posts (e.g. pulled in by extension relationships) — the non-contiguity that caused #4137. Verified the contiguity assertions fail if the guard is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4703, adding the regression coverage that PR didn't include.
This area of the post stream has now been reworked three times (#4137 → #4156 → #4703) without a test pinning the behaviour, which is a large part of why it kept re-breaking. This locks it in.
tests/unit/forum/states/PostStreamState.test.tscovers:null/perpetually-loading entry).preloadedNearPage()contiguity guard ([2.0.0-beta.1] Opening a discussion not always loads all posts #4137): returns only the longest contiguous run of store-loaded posts. A stray non-contiguous post (e.g. pulled in by an extension relationship) is dropped, and feeding the resulting seed into the stream produces a clean, gap-free window. Also covers "longest of several runs wins" and "nothing loaded → empty array".I confirmed these are real regression tests, not just green: with the contiguity guard removed (reverted to a naive "all loaded posts"
preloadedNearPage), the two #4137 assertions fail as expected; with the fix in place all 7 pass.Pure test addition — no source changes.