Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
blento | b3b5802 | Apr 08 2026, 10:44 PM |
Owner
|
sorry took me a while to review this, i've taken out the other than that looks good to me 👍 |
Contributor
Author
iirc idea was that instead of having no feedback, or causing the page to not render until the data is ready, have a loading state to give user feedback - the design could be improved but it's important change imo. I don't think it was about editing, but I could be mis-remembering |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following cards for the scrobbling service ListenBrainz:
I also used this as an opportunity to introduce some potential improvements to the remote functions use to try and reduce complexity, as well as bringing in Valibot to validate the input. Let me know if you want any changes, and if any of it gets merged then I'm happy to make the changes to other parts of the codebase.