Skip to content

feat: pgp encryption#1487

Merged
andrinoff merged 16 commits into
floatpane:release/v1from
andrinoff:feat/v1-pgp-encryption
Jun 20, 2026
Merged

feat: pgp encryption#1487
andrinoff merged 16 commits into
floatpane:release/v1from
andrinoff:feat/v1-pgp-encryption

Conversation

@LeaWhoCodes

@LeaWhoCodes LeaWhoCodes commented Jun 18, 2026

Copy link
Copy Markdown
Member

What?

Adds PGP encryption to matcha via a file-based key and a smartcard (yubikey)

Why?

It was postboned due to several errors (read more on discord) This hopefully fully works.

@LeaWhoCodes @andrinoff @steveevansdev
feat: pgp encryption
c423040 
Co-authored-by: drew <me@andrinoff.com>
Co-authored-by: Steve Evans <steve@floatpane.com>
@LeaWhoCodes LeaWhoCodes requested a review from a team as a code owner June 18, 2026 11:16
@floatpanebot floatpanebot added target/v1 PR targets the release/v1 branch directly enhancement New feature or request size/XL Diff: 800+ lines labels Jun 18, 2026
@LeaWhoCodes LeaWhoCodes marked this pull request as draft June 18, 2026 11:16
@floatpanebot floatpanebot added dependencies Dependency updates area/pgp PGP / encryption area/scard Smart card / PKCS#11 labels Jun 18, 2026
andrinoff and others added 4 commits June 18, 2026 15:18
@andrinoff
fix: update the version from local
2c66247 
Signed-off-by: drew <me@andrinoff.com>
@andrinoff
test: integration tests
05d2663 
Signed-off-by: drew <me@andrinoff.com>
@LeaWhoCodes @andrinoff
chore: lint
37c74fc 
Signed-off-by: drew <me@andrinoff.com>
@andrinoff
fix: adllow .pem signatures
f4ef4e2 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot

floatpanebot commented Jun 18, 2026

Copy link
Copy Markdown
Member

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@floatpanebot

floatpanebot commented Jun 18, 2026

Copy link
Copy Markdown
Member

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@floatpanebot

floatpanebot commented Jun 18, 2026

Copy link
Copy Markdown
Member

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff

andrinoff commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

✅ test pass locally with the Yubikey support (benchmark, needs practical testing still)

@andrinoff

andrinoff commented Jun 18, 2026

Copy link
Copy Markdown
Member

✅ tests pass with file-based keys too

@andrinoff
fix: remove dupword
a801601 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot

floatpanebot commented Jun 18, 2026

Copy link
Copy Markdown
Member

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff andrinoff mentioned this pull request Jun 18, 2026
Open
1 task
@andrinoff
make signatures work
ed53fd5 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot floatpanebot added area/tui Terminal UI / view layer area/sender SMTP send path area/i18n Localization / translations area/daemon Daemon / RPC labels Jun 19, 2026
@floatpanebot

floatpanebot commented Jun 19, 2026

Copy link
Copy Markdown
Member

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff
fix: file based decryption
9a74776 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot floatpanebot added the area/fetcher IMAP fetch / IDLE / search label Jun 19, 2026
@floatpanebot

floatpanebot commented Jun 19, 2026

Copy link
Copy Markdown
Member

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

andrinoff added 2 commits June 19, 2026 21:52
@andrinoff
squash
ac84923 
Signed-off-by: drew <me@andrinoff.com>
@andrinoff
fix: smartcard decryption
0a0cf42 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot

floatpanebot commented Jun 20, 2026

Copy link
Copy Markdown
Member

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff andrinoff marked this pull request as ready for review June 20, 2026 06:25
@andrinoff
fix: move logs to loglevel and docs
93a8306 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot floatpanebot added the area/docs Docs site / README label Jun 20, 2026
andrinoff
andrinoff previously approved these changes Jun 20, 2026
View reviewed changes
@floatpanebot

floatpanebot commented Jun 20, 2026

Copy link
Copy Markdown
Member

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff
Merge remote-tracking branch 'origin/release/v1' into feat/v1-pgp-enc…
38569b3 
…ryption

Signed-off-by: drew <me@andrinoff.com>
@floatpanebot

floatpanebot commented Jun 20, 2026

Copy link
Copy Markdown
Member

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff andrinoff enabled auto-merge June 20, 2026 06:32
andrinoff
andrinoff previously approved these changes Jun 20, 2026
View reviewed changes
@andrinoff
fix: remove replace
a4aa4c5 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot

floatpanebot commented Jun 20, 2026

Copy link
Copy Markdown
Member

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff
fix: lint
69dd44d 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot

floatpanebot commented Jun 20, 2026

Copy link
Copy Markdown
Member

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff andrinoff disabled auto-merge June 20, 2026 06:44
@andrinoff andrinoff merged commit f6e7fb2 into floatpane:release/v1 Jun 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrinoff andrinoff andrinoff approved these changes

Assignees

No one assigned

Labels

area/daemon Daemon / RPC area/docs Docs site / README area/fetcher IMAP fetch / IDLE / search area/i18n Localization / translations area/pgp PGP / encryption area/scard Smart card / PKCS#11 area/sender SMTP send path area/tui Terminal UI / view layer dependencies Dependency updates enhancement New feature or request size/XL Diff: 800+ lines target/v1 PR targets the release/v1 branch directly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LeaWhoCodes @floatpanebot @andrinoff @steveevansdev