fix(tui): sync unread badge on delete#1491
Open
youdie006 wants to merge 1 commit into
Open
Conversation
The delete/archive Update handlers mutated the unread stores but never recomputed the badge, so the unread counter only refreshed on the next fetch. Call m.syncUnreadBadge() after the store mutation in DeleteEmailMsg, ArchiveEmailMsg, BatchDeleteEmailsMsg and BatchArchiveEmailsMsg, mirroring the read/unread handlers. syncUnreadBadge now also caches the count on every OS so the behavior is testable. Closes floatpane#1404
floatpanebot
previously requested changes
Jun 19, 2026
floatpanebot
left a comment
floatpanebot
left a comment
Member
There was a problem hiding this comment.
Hi @youdie006! Please fix the following issues with your PR:
- Title: Is too long (40 characters). The PR title must be strictly under 40 characters.
- Body: Missing the
## What?or## Why?headings required by the PR template.
Member
Benchmark report — no significant changeMetrics worse: 0 · better: 0 (threshold: ±3%). benchstat outputauto-generated by benchmarks.yml |
youdie006
changed the title
floatpanebot
dismissed
their stale review
Formatting issues have been resolved. Thank you!
Member
|
@youdie006 thank you for your contribution. The issue was not about this badge, but rather the folder unread. Unlinking the issue, I'll check out the PR a bit later. |
Member
|
/backport v1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
After deleting or archiving emails, the delete/archive
Updatehandlers (DeleteEmailMsg,ArchiveEmailMsg,BatchDeleteEmailsMsg,BatchArchiveEmailsMsg) now callm.syncUnreadBadge(), mirroring the read/unread handlers, so the unread badge recomputes immediately.syncUnreadBadgealso caches the count on every OS so the behavior is unit-testable. Adds four tests asserting the macOS badge drops to 0 after the last unread email is deleted/archived.Why?
The delete/archive handlers mutated the unread stores but never recomputed the unread menu bar badge, so the counter only refreshed on the next fetch.