Skip to content

Don't remove already existing file when doing partitioning#2240

Closed
stloyd wants to merge 1 commit intoflow-php:1.xfrom
stloyd:bugfix/2239
Closed

Don't remove already existing file when doing partitioning#2240
stloyd wants to merge 1 commit intoflow-php:1.xfrom
stloyd:bugfix/2239

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Mar 1, 2026

Resolves: #2239

Change Log


Added

Fixed

  • Don't remove already existing file when doing partitioning

Changed

Removed

Deprecated

Security

@stloyd stloyd requested a review from norberttech as a code owner March 1, 2026 17:23
@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.00%. Comparing base (fa04987) to head (06a37e8).
⚠️ Report is 5 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #2240      +/-   ##
==========================================
+ Coverage   82.79%   83.00%   +0.20%     
==========================================
  Files        1360     1360              
  Lines       50550    50550              
==========================================
+ Hits        41855    41960     +105     
+ Misses       8695     8590     -105     
Components Coverage Δ
etl 90.17% <100.00%> (+0.83%) ⬆️
cli 85.76% <ø> (ø)
lib-array-dot 94.82% <ø> (ø)
lib-azure-sdk 60.01% <ø> (ø)
lib-doctrine-dbal-bulk 95.16% <ø> (ø)
lib-filesystem 83.42% <ø> (ø)
lib-types 88.88% <ø> (+1.50%) ⬆️
lib-parquet 68.25% <ø> (ø)
lib-parquet-viewer 83.04% <ø> (ø)
lib-snappy 90.18% <ø> (ø)
lib-dremel 0.00% <ø> (ø)
lib-postgresql 88.13% <ø> (ø)
lib-telemetry 89.57% <ø> (ø)
bridge-filesystem-async-aws 90.95% <ø> (ø)
bridge-filesystem-azure 89.38% <ø> (ø)
bridge-monolog-http 97.45% <ø> (ø)
bridge-openapi-specification 91.50% <ø> (ø)
symfony-http-foundation 74.11% <ø> (ø)
bridge-psr18-telemetry 100.00% <ø> (ø)
bridge-psr7-telemetry 100.00% <ø> (ø)
bridge-telemetry-otlp 89.29% <ø> (+0.25%) ⬆️
bridge-symfony-http-foundation-telemetry 88.23% <ø> (ø)
bridge-symfony-telemetry-bundle 67.60% <ø> (ø)
adapter-chartjs 84.72% <ø> (ø)
adapter-csv 88.65% <ø> (ø)
adapter-doctrine 92.00% <ø> (ø)
adapter-elasticsearch 92.78% <ø> (ø)
adapter-google-sheet 99.02% <ø> (ø)
adapter-http 67.91% <ø> (ø)
adapter-json 87.61% <ø> (ø)
adapter-logger 47.36% <ø> (ø)
adapter-parquet 79.29% <ø> (ø)
adapter-text 81.25% <ø> (ø)
adapter-xml 82.07% <ø> (ø)
adapter-avro 0.00% <ø> (ø)
adapter-excel 94.02% <ø> (ø)
adapter-postgresql 0.00% <ø> (ø)
bridge-phpunit-telemetry 48.14% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech
Copy link
Member

honestly I'm on a fence with this one, on the one hand, it seems to be mergable, but if we merge it, we are creating a rule that partitioning with overwrite mode should only remove the expected partition file - and I'm not sure how this will impact parallel processing.

So if this is really problematic for your use case, maybe lets take a look together at your use case so I can get better understanding of what you are trying to achieve as there might be a different solution

@norberttech norberttech closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Filesystem partition saving run with overwrite removes all files not just the related ones

2 participants