Don't remove already existing file when doing partitioning#2240
Closed
stloyd wants to merge 1 commit intoflow-php:1.xfrom
Closed
Don't remove already existing file when doing partitioning#2240stloyd wants to merge 1 commit intoflow-php:1.xfrom
stloyd wants to merge 1 commit intoflow-php:1.xfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2240 +/- ##
==========================================
+ Coverage 82.79% 83.00% +0.20%
==========================================
Files 1360 1360
Lines 50550 50550
==========================================
+ Hits 41855 41960 +105
+ Misses 8695 8590 -105
🚀 New features to boost your workflow:
|
Member
|
honestly I'm on a fence with this one, on the one hand, it seems to be mergable, but if we merge it, we are creating a rule that partitioning with overwrite mode should only remove the expected partition file - and I'm not sure how this will impact parallel processing. So if this is really problematic for your use case, maybe lets take a look together at your use case so I can get better understanding of what you are trying to achieve as there might be a different solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2239
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security