Fixed resources, fluentd & fluent bit, and what is fluent bit doc sections under the About header#2386
Conversation
- Change "sub-project" to "graduated project" in front matter description Applies to fluent#2385 Signed-off-by: Eric D. Schabell <eric@schabell.org>
…stats - Update Fluent Bit memory footprint from ~1 MB to ~450 KB - Update deployment stat to reflect 15 billion global deployments Applies to fluent#2385 Signed-off-by: Eric D. Schabell <eric@schabell.org>
d347473 to
51d55ee
Compare
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates about-site docs: revises Fluent Bit's CNCF classification, adjusts global deployment and memory-footprint figures, modifies a workshop entry to focus on Fluent Bit pod logging on Kubernetes with an updated embed URL, and adds a Vale TokenIgnores pattern. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@patrick-stephens and @cosmo0920 ready for review! |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@about/fluentd-and-fluent-bit.md`:
- Line 25: Add inline citations for the "Approximately 450 KB" memory
figure in the table row "| Memory | Greater than 60 MB |
Approximately 450 KB |" by referencing Fluent Bit's official documentation
(docs.fluentbit.io and fluentbit.io) where the "minimal footprint" / 450 KB
number is stated; update the markdown to include one or two parenthetical or
footnote-style citations immediately after "Approximately 450 KB" that
point to the exact Fluent Bit manual pages describing the minimal footprint.
- Line 13: The sentence "Production-grade solutions, with Fluent Bit deployed
over 15 billion times globally." needs a citation—edit that line in
about/fluentd-and-fluent-bit.md to turn the phrase "Fluent Bit" (or the whole
claim) into a Markdown link pointing to Fluent Bit's official site (e.g.
https://fluentbit.io/) so the deployment statistic is verifiable; ensure the
link uses standard Markdown link syntax and preserves the original wording.
In `@about/resources.md`:
- Around line 32-36: The embed block for the Fluent Bit workshop is missing its
closing tag and descriptive text; locate the opening embed with
URL="https://eksworkshop.com/docs/observability/logging/pod-logging/fluentbit-setup"
and add a short descriptive line (e.g., "AWS workshop covering Fluent Bit
pod-level logging on Kubernetes with CloudWatch Logs integration") followed by
the closing tag {% endembed %} so the block matches the pattern used by the
other embeds.
- Line 15: The embed tag uses an uppercase attribute "URL" which breaks GitBook
parsing; change the tag from {% embed
URL="https://o11y-workshops.gitlab.io/workshop-fluentbit/" %} to use a lowercase
attribute name so it reads {% embed
url="https://o11y-workshops.gitlab.io/workshop-fluentbit/" %} (update the embed
tag's attribute only, leaving the rest of the tag unchanged).
patrick-stephens
left a comment
There was a problem hiding this comment.
Looks fine to me but CodeRabbit flagged a few issues with the Gitbook setup that probably need resolving.
- Update Amazon workshop URL to point to Fluent Bit pod logging page - Update section heading to reflect actual workshop content - Update description to accurately reflect CloudWatch Logs routing Applies to fluent#2385 Signed-off-by: Eric D. Schabell <eric@schabell.org>
51d55ee to
b95d857
Compare
Signed-off-by: Eric D. Schabell <eric@schabell.org>
a2c64b9 to
438cf05
Compare
|
@patrick-stephens can I get a final review, as I've fixed the bot issues and adjusted Vale settings to pass on gitbook embedded images (the URL thing). |
Fixes #2385
Summary by CodeRabbit