Conversation
d13ed26 to
b9e332b
Compare
kenhys
reviewed
Mar 21, 2024
|
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days |
Contributor
Author
|
Missed a comment. Don't close. |
Contributor
Author
|
Wait with this, I have some more improvements. |
Reduces the alpine image from 46M to 36M, and debian image from 210M to 195M. yajl parts can be removed if/when brianmario/yajl-ruby#228 is merged and released. Signed-off-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>
kenhys
approved these changes
Sep 10, 2024
Contributor
kenhys
left a comment
There was a problem hiding this comment.
LGTM.
Here is the simple stats:
podman images |grep fluentd
localhost/fluentd-alpine latest 2918f8d3973c 17 seconds ago 49.9 MB
localhost/fluentd-debian latest 4ae0e7ea34fc About a minute ago 220 MB
localhost/fluentd-alpine-reduce latest 92dcc72f2f3c 4 minutes ago 39.1 MB
localhost/fluentd-debian-reduce latest a4d016dcfb19 6 hours ago 204 MB
Contributor
Author
|
Thanks @kenhys. With docker-library/ruby#472 the debian images can be reduced even more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces the alpine image from 46M to 36M and debian image from 210M to 195M.
yajl parts can be removed if/when brianmario/yajl-ruby#228 is merged and released.