Skip to content

test(efc): initialize runtime type in runtime info helper#5953

Open
NO1SETTER wants to merge 1 commit into
fluid-cloudnative:masterfrom
NO1SETTER:bg-lab1-652022330038
Open

test(efc): initialize runtime type in runtime info helper#5953
NO1SETTER wants to merge 1 commit into
fluid-cloudnative:masterfrom
NO1SETTER:bg-lab1-652022330038

Conversation

@NO1SETTER
Copy link
Copy Markdown

What is changed

Initialize runtimeType in newEFCEngineRT test helper.

Why

In production code, EFCEngine is initialized with a runtime type.
The test helper previously did not set this field, which made the test object inconsistent with the real engine initialization path.

This change aligns the test helper with the production behavior and makes the runtime info related test setup more accurate.

Verification

  • Ran:
    GO111MODULE=on GOWORK=off GOFLAGS=-mod=vendor GOCACHE=/private/tmp/fluid-gocache go test ./pkg/ddc/efc -run TestEFCEngine_getRuntimeInfo -count=1
  • Result: ok

Related issue

Related to #5952

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ronggu for approval by writing /assign @ronggu in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 3, 2026

Hi @NO1SETTER. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the newEFCEngineRT test helper function in pkg/ddc/efc/runtime_info_test.go to initialize the runtimeType field with common.EFCRuntime. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant