-
Notifications
You must be signed in to change notification settings - Fork 100
Simplify failed checks search for re-run #4925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
autosubmit label was removed for flutter/cocoon/4925, because Pull request flutter/cocoon/4925 is not in a mergeable state. |
… need to look up for failed checks in both, only last guard might have failed checks.
|
autosubmit label was removed for flutter/cocoon/4925, because This PR has not met approval requirements for merging. Changes were requested by {jtmcdole}, please make the needed changes and resubmit this PR.
|
|
autosubmit label was removed for flutter/cocoon/4925, because - The status or check suite test-common-packages (auto_submit) has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
autosubmit label was removed for flutter/cocoon/4925, because This PR has not met approval requirements for merging. Changes were requested by {jtmcdole}, please make the needed changes and resubmit this PR.
|
|
autosubmit label was removed for flutter/cocoon/4925, because - The status or check suite test-common-packages (packages/cocoon_common_test) has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
…f'. Try using '?'. - use_null_aware_elements"
|
autosubmit label was removed for flutter/cocoon/4925, because This PR has not met approval requirements for merging. Changes were requested by {jtmcdole}, please make the needed changes and resubmit this PR.
|
| required Config config, | ||
| PullRequest? pullRequest, | ||
| CheckRun? checkRun, | ||
| @visibleForTesting DateTime Function() utcNow = DateTime.timestamp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constructs a DateTime with the current UTC date and time.
Neat!
Fusion checks are scheduled only if there are no engine checks needed or all engine checks are succeeded.
Therefore if several check guards exists no need to search for failed checks across all existed but only latest one may have failed checks.
Fixes: flutter/flutter#181334