Fix patternToPath to throw when path parameter is missing

[jhonathanqz]

[go_router] Fix patternToPath to throw when path parameter is missing

Previously, patternToPath wrote the literal string "null" into the generated URL when a path parameter required by the pattern was missing from the pathParameters map. This produced invalid URLs and made debugging difficult. This PR makes patternToPath throw a GoException with a clear message (e.g. "Missing path parameter: bookId") when a required parameter is missing, so callers get fail-fast behavior instead of silently generating wrong URLs.

List which issues are fixed by this PR. You must list at least one issue.

Changes in this PR:

• lib/src/path_utils.dart: patternToPath now throws GoException when a path parameter is missing.
• test/path_utils_test.dart: New test patternToPath throws when path parameter is missing.
• pubspec.yaml: Version bumped to 17.1.1.
• CHANGELOG.md: Added 17.1.1 entry.

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[gemini-code-assist]

Code Review

This pull request updates the patternToPath function to throw a GoException when a required path parameter is missing, preventing the creation of invalid URLs containing "null". A new test is added to verify this fail-fast behavior.

[stuartmorgan-g]

Thanks for the contribution! You haven’t checked off any of the items in the PR checklist above, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

[gemini-code-assist]

Code Review

This pull request modifies the patternToPath function to throw a GoException if a required path parameter is missing, preventing the creation of invalid URLs with "null" values. The change includes a new test to verify this fail-fast behavior, a version bump to 17.1.1 in pubspec.yaml, and an update to CHANGELOG.md.

[chunhtai]

code looks fine, but ci is not happy

[chunhtai]

for go_router, please create a changelog entry in pending_changes