Skip to content

Sync analysis_options.yaml with flutter/flutter#11823

Open
stuartmorgan-g wants to merge 4 commits into
flutter:mainfrom
stuartmorgan-g:ananlysis-sync-flutter-2026-05-11
Open

Sync analysis_options.yaml with flutter/flutter#11823
stuartmorgan-g wants to merge 4 commits into
flutter:mainfrom
stuartmorgan-g:ananlysis-sync-flutter-2026-05-11

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

Pulls in changes from flutter/flutter's analysis_options.yaml since the last since at the end of 2023.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the analysis_options.yaml configuration to align with a newer version of the Flutter repository, enabling several linter rules including avoid_final_parameters and unnecessary_underscores. To comply with these new rules, the changes replace multi-underscore unused parameters with single underscores and remove the final keyword from parameter declarations across multiple packages. There are no review comments to address, and no additional feedback is provided.

Copy link
Copy Markdown
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Thank you for the help here!

@justinmc
Copy link
Copy Markdown
Contributor

justinmc commented Jun 2, 2026

Looks like there's still some analyzer errors:

   info - lib/src/common/pub_version_finder.dart:54:12 - Parameters should not be marked as 'final'. Try removing the keyword 'final'. - avoid_final_parameters
   info - lib/src/fetch_deps_command.dart:290:5 - Parameters should not be marked as 'final'. Try removing the keyword 'final'. - avoid_final_parameters
   info - test/common/output_utils_test.dart:99:16 - Unnecessary use of multiple underscores. Try using '_'. - unnecessary_underscores
   info - test/common/output_utils_test.dart:99:20 - Unnecessary use of multiple underscores. Try using '_'. - unnecessary_underscores
   info - test/license_check_command_test.dart:477:11 - Don't use adjacent strings in a list literal. Try adding a comma between the strings. - no_adjacent_strings_in_list
   info - test/util.dart:366:16 - Unnecessary use of multiple underscores. Try using '_'. - unnecessary_underscores
   info - test/util.dart:366:20 - Unnecessary use of multiple underscores. Try using '_'. - unnecessary_underscores

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 2, 2026
@Piinks Piinks added the CICD Run CI/CD label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants