Sync analysis_options.yaml with flutter/flutter#11823
Open
stuartmorgan-g wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the analysis_options.yaml configuration to align with a newer version of the Flutter repository, enabling several linter rules including avoid_final_parameters and unnecessary_underscores. To comply with these new rules, the changes replace multi-underscore unused parameters with single underscores and remove the final keyword from parameter declarations across multiple packages. There are no review comments to address, and no additional feedback is provided.
justinmc
approved these changes
Jun 2, 2026
Contributor
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Thank you for the help here!
Contributor
|
Looks like there's still some analyzer errors: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in changes from flutter/flutter's analysis_options.yaml since the last since at the end of 2023.
invalid_runtime_check_with_js_interop_typesis disabled for now; see [various]invalid_runtime_check_with_js_interop_typesviolations in web packages flutter#187454dart fix --applyhas been run on all packages, which auto-fixed a lot of cases ofunnecessary_underscores, and a handful ofavoid_final_parameters