Skip to content

docs: clarify HomeViewModel lifecycle in Compass sample #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshyadavDeveloper wants to merge 2 commits into
base: main
Choose a base branch
from
+41 −7
Open

docs: clarify HomeViewModel lifecycle in Compass sample #2838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93d3dfa
docs: clarify HomeViewModel lifecycle in Compass sample
harshyadavDeveloper Apr 30, 2026
c82e3b5
refactor: manage HomeViewModel lifecycle in StatefulWidget
harshyadavDeveloper May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions compass_app/app/lib/routing/router.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ import '../ui/auth/login/view_models/login_viewmodel.dart';
import '../ui/auth/login/widgets/login_screen.dart';
import '../ui/booking/view_models/booking_viewmodel.dart';
import '../ui/booking/widgets/booking_screen.dart';
import '../ui/home/view_models/home_viewmodel.dart';
import '../ui/home/widgets/home_screen.dart';
import '../ui/home/widgets/home_screen_container.dart';
import '../ui/results/view_models/results_viewmodel.dart';
import '../ui/results/widgets/results_screen.dart';
import '../ui/search_form/view_models/search_form_viewmodel.dart';
Expand Down Expand Up @@ -42,11 +41,7 @@ GoRouter router(AuthRepository authRepository) => GoRouter(
GoRoute(
path: Routes.home,
builder: (context, state) {
final viewModel = HomeViewModel(
bookingRepository: context.read(),
userRepository: context.read(),
);
return HomeScreen(viewModel: viewModel);
return const HomeScreenContainer();
},
routes: [
GoRoute(
Expand Down
39 changes: 39 additions & 0 deletions compass_app/app/lib/ui/home/widgets/home_screen_container.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import 'package:flutter/widgets.dart';
import 'package:provider/provider.dart';

import '../../../data/repositories/booking/booking_repository.dart';
import '../../../data/repositories/user/user_repository.dart';
import '../view_models/home_viewmodel.dart';
import 'home_screen.dart';

class HomeScreenContainer extends StatefulWidget {
const HomeScreenContainer({super.key});

@override
State<HomeScreenContainer> createState() => _HomeScreenContainerState();
}

class _HomeScreenContainerState extends State<HomeScreenContainer> {
late final HomeViewModel _viewModel;

@override
void initState() {
super.initState();

_viewModel = HomeViewModel(
bookingRepository: context.read<BookingRepository>(),
userRepository: context.read<UserRepository>(),
);
}

@override
void dispose() {
_viewModel.dispose();
super.dispose();
}

@override
Widget build(BuildContext context) {
return HomeScreen(viewModel: _viewModel);
}
}