Conversation
Summary of ChangesHello @jwill, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands and refines the documentation for Android platform integration within Flutter. It introduces Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR significantly refactors the documentation around native platform integration, introducing jnigen as a primary way to interact with native Android code. It adds several new pages explaining jnigen and providing examples for launching activities and requesting permissions. The existing documentation is updated to reflect this new structure. Overall, this is a great improvement to the documentation. I've found a few issues, mostly in the code snippets within the markdown files, such as duplicated dependencies and incorrect language tags for code blocks. There are also some minor typos and inconsistencies that should be addressed to improve clarity.
|
|
||
| The APISummarizer is a tool that reads source and bytecode to determine which classes and functions are present. The abstract syntax tree defining the desired classes is read to create Dart versions with modifications to account for the differences between the Java platform and Dart. | ||
|
|
||
| Diagram should go here |
| 'androidx.activity.result.ActivityResultLauncher', | ||
| 'androidx.activity.result.contract.ActivityResultContract', | ||
| 'android.content.Intent', | ||
| //'android.content.Context', |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Visit the preview URL for this PR (updated for commit d219e50): https://flutter-docs-prod--pr13115-native-interop-things-pya9nu29.web.app |
Removed placeholder for diagram and extra line breaks.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
lamek
left a comment
There was a problem hiding this comment.
Some style updates, a few nits, and 2 suggestions. Looking really good. I'll have more higher level perspective as I come up to speed on interop.
| --- | ||
| title: Writing custom platform-specific code | ||
| shortTitle: Platform-specific code | ||
| description: Learn how about the options to call platform specific code in your app. |
There was a problem hiding this comment.
Remove "how". Update to "platform-specific".
|
|
||
| ## Overview | ||
|
|
||
| You have a number of options to use platform-specific code |
There was a problem hiding this comment.
Suggestion: break this up.
"You have several options for using platform-specific code in your Dart and Flutter apps. These range from low-level options requiring deep knowledge of the host language, to high-level options that abstract the native components behind an API."
|
|
||
| Execute `dart run tool/jnigen.dart` to generate the Dart bindings. | ||
|
|
||
| With the bindings generated, we can directly |
There was a problem hiding this comment.
Complete this sentence.
"...directly call them in your Dart code."
There was a problem hiding this comment.
Change "we" --> "you".
Can you ctrl-f for "we " (do we with the space). There are 4 instances throughout.
|
|
||
| ### On the command line | ||
|
|
||
| On the commandline, add `jnigen` as a development dependency |
| On the Android side, you will need to make some modifications to some Android build | ||
| files to account for Compose views and a new `Activity`. | ||
|
|
||
| The [code][] for this version is available on Github. |
|
|
||
| ### On the Dart side | ||
|
|
||
| In your dart code, create jnigen.dart file specifying the |
There was a problem hiding this comment.
nit: capital "D": "Dart code"
| ``` | ||
|
|
||
| ### Step 3: Set configuration of Dart bindings | ||
| There is a Dart API in `jnigen` to specify the properties your generated should have. You will create |
There was a problem hiding this comment.
Missing word - "code".
"...specify the properties your generated code should have."
| Here is the full `main.dart` file. | ||
|
|
||
| :::note | ||
| Java/Kotlin and Dart differ on support of overloaded functions, that's to say functions that use the same |
There was a problem hiding this comment.
Suggestion: rephrase this.
"Java/Kotlin and Dart differ in their support for overloaded functions (functions that share a name but have different return types or parameters)."
| This page details a means to use `jnigen` to wrap native Android code and package that functionality | ||
| as a plugin. It demonstrates requesting and querying Android permissions natively from Flutter. | ||
|
|
||
| With this flow, one only has to edit a single file on the Android side. |
There was a problem hiding this comment.
I wouldn't use "one only" (I get what you're saying).
Try "you only need to..." instead.
Description of what this PR is changing or adding, and why:
This is PR is reimagining some of the Platform Integration section for demonstration purposes. Consider it a draft to advance the conversation.
Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.