Skip to content

[fwe] Fix Tile constructor parameters#13174

Merged
parlough merged 5 commits intomainfrom
fix/fwe-tile-constructors
Mar 12, 2026
Merged

[fwe] Fix Tile constructor parameters#13174
parlough merged 5 commits intomainfrom
fix/fwe-tile-constructors

Conversation

@parlough
Copy link
Member

@parlough parlough commented Mar 12, 2026

Initial syntax and name fixes, with larger fixes coming with Kevin's code excerpt work.

Fixes #13162
Fixes #13163

@parlough parlough requested review from a team and sfshaza2 as code owners March 12, 2026 19:41
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects the Tile widget's constructor syntax in several documentation files. The removal of the required keyword from positional parameters is a valid fix, making the Dart code snippets syntactically correct. The changes are correct as is. For future improvements, you might consider addressing other typos in the code snippets within src/content/learn/pathway/tutorial/implicit-animations.md to enhance the quality of the tutorial, such as a switch statement using an incorrect variable (type instead of hitType) and an incorrect enum type (LetterType instead of HitType).

@parlough parlough requested a review from lamek March 12, 2026 19:42
Copy link
Contributor

@lamek lamek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Mar 12, 2026

Visit the preview URL for this PR (updated for commit d5dc0a7):

https://flutter-docs-prod--pr13174-fix-fwe-tile-constructors-98a1dysd.web.app

@parlough parlough merged commit 019d90c into main Mar 12, 2026
10 checks passed
@parlough parlough deleted the fix/fwe-tile-constructors branch March 12, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several possible source code errors Possible depreciated code being used.

3 participants