Add git commit/tag ssh signature verification#2077
Merged
stefanprodan merged 1 commit intoJun 12, 2026
Merged
Conversation
stefanprodan
reviewed
Jun 9, 2026
bb-Ricardo
force-pushed
the
rb-feature/adds-git-commit-ssh-signature-verification
branch
from
c5a36db to
4624aab
Compare
bb-Ricardo
commented
Jun 9, 2026
|
|
||
| var keyRings []string | ||
| for _, v := range secret.Data { | ||
| keyRings = append(keyRings, string(v)) |
Contributor
Author
There was a problem hiding this comment.
The current implementation does not implement what is stated in the documentation: https://fluxcd.io/flux/components/source/gitrepositories/#verification-secret-example
Any key (not just .asc) is used for PGP public keys. Therefore a fallback is implemented to not break current setups
stefanprodan
changed the title
stefanprodan
added
area/git
Member
|
@bb-Ricardo please rebase |
Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
bb-Ricardo
force-pushed
the
rb-feature/adds-git-commit-ssh-signature-verification
branch
from
4624aab to
f565efe
Compare
stefanprodan
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds git commit and tag SSH signature validation.
Ref: #1996