fix: EnumTransformer.to_literal accepts a string matching an enum value#3439
Open
1fanwang wants to merge 1 commit into
Open
fix: EnumTransformer.to_literal accepts a string matching an enum value#34391fanwang wants to merge 1 commit into
1fanwang wants to merge 1 commit into
Conversation
1fanwang
requested review from
cosmicBboy,
davidmirror-ops,
kumare3,
machichima,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
force-pushed
the
enum-to-literal-accepts-string
branch
from
f995050 to
11c9eaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
EnumTransformer.assert_typeaccepts a raw string that matches one of the enum's values (for instance an enum default supplied as a string), butEnumTransformer.to_literalrejects that same string withExpected an enum. So a matching-string value passes type-checking and then fails at serialization.What changes were proposed in this pull request?
to_literalnow accepts a string matching one of the enum's values and serializes it to the corresponding literal, consistent withassert_type. A non-matching string is still rejected.How was this patch tested?
Added
test_enum_to_literal_accepts_matching_string— it fails on the current code withTypeTransformerFailedError: Expected an enumand passes with the fix.Check all the applicable boxes