Honour useMarkFilteringSet lookup flag during glyph iteration#373
Open
lehni wants to merge 1 commit into
Open
Conversation
- Skip marks not in the lookup's filtering set per OT spec - Overrides ignoreMarks and markAttachmentType for marks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks outside a lookup's filtering set must be skipped during iteration per the OT spec —
useMarkFilteringSetoverrides bothignoreMarksandmarkAttachmentTypefor marks. Without honouring it, contextual rules either fail to fire or fire on the wrong context, and mark-to-mark positioning attaches to the wrong candidate.The lookup's filtering set is resolved lazily into a
Set<glyphId>(cached per Coverage), threaded throughGlyphIterator.reset, and checked inshouldIgnorebefore the legacy mark-skipping flags.Test note
The added Mada test exercises an
rcltchain whose backtrack also depends on #372 (chain-context backtrack matching order). Both fixes are needed for the test to demonstrate its expected behaviour — the test will pass once #372 lands and this PR is rebased on top.