FIX @W-21506501@ Adding changes to enable parsing by default#433
Merged
namrata111f merged 2 commits intodevfrom Mar 10, 2026
Merged
FIX @W-21506501@ Adding changes to enable parsing by default#433namrata111f merged 2 commits intodevfrom
namrata111f merged 2 commits intodevfrom
Conversation
Contributor
Author
Have manually tested all the possible scenarios. Did not add any new UT since UTs were covered as part of your previous PR itself. |
aruntyagiTutu
approved these changes
Mar 10, 2026
Contributor
Author
|
Have added new UTs as well to verify unnecessary rules are not being executed depending on the config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling parsing of the files irrespective of the config values selected. Currently we sometimes add parser for the file or sometimes skip it depending on config values. This can lead to some inconsistent states where parsing runs into error. Going forward we will have consistent behavior of adding the parser and skipping execution of the rules depending on the config values.
Have manually tested for all the possible combinations of config values we can have: https://docs.google.com/document/d/18n5OmWVVRlqI3meBmWi1cSjnqbUEqLZ6nG1hVGsuwsU/edit?usp=sharing