Skip to content

FIX @W-21506501@ Adding changes to enable parsing by default#433

Merged
namrata111f merged 2 commits intodevfrom
ng-enable-parsing
Mar 10, 2026
Merged

FIX @W-21506501@ Adding changes to enable parsing by default#433
namrata111f merged 2 commits intodevfrom
ng-enable-parsing

Conversation

@namrata111f
Copy link
Contributor

@namrata111f namrata111f commented Mar 9, 2026

Enabling parsing of the files irrespective of the config values selected. Currently we sometimes add parser for the file or sometimes skip it depending on config values. This can lead to some inconsistent states where parsing runs into error. Going forward we will have consistent behavior of adding the parser and skipping execution of the rules depending on the config values.
Have manually tested for all the possible combinations of config values we can have: https://docs.google.com/document/d/18n5OmWVVRlqI3meBmWi1cSjnqbUEqLZ6nG1hVGsuwsU/edit?usp=sharing

Copy link
Contributor

@aruntyagiTutu aruntyagiTutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are existing tests enough to catch all scenrio with this optimization ?

@namrata111f
Copy link
Contributor Author

are existing tests enough to catch all scenrio with this optimization ?

Have manually tested all the possible scenarios. Did not add any new UT since UTs were covered as part of your previous PR itself.

@namrata111f
Copy link
Contributor Author

Have added new UTs as well to verify unnecessary rules are not being executed depending on the config.

@namrata111f namrata111f merged commit 1bc8840 into dev Mar 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants