-
Notifications
You must be signed in to change notification settings - Fork 2
Add first-launch onboarding message #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Display a brief welcome message in grey text on first launch, explaining: - Cmd+N/W for terminal management - Cmd+Enter for focus toggle - Hold Escape to interrupt agents - architect hook command for AI agent integration The message is shown once and tracked via onboarding_shown in persistence.toml. https://claude.ai/code/session_013AMHvCsisuoq8T8BroZKs4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a first-launch onboarding message that displays keyboard shortcuts and AI agent integration instructions to new users. The message appears in grey text on first launch and is tracked via a persistence flag.
Changes:
- Added
onboarding_shownboolean flag to persistence configuration - Implemented first-launch detection and welcome message display in runtime
- Updated documentation to reflect the new persistence field
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/config.zig | Added onboarding_shown field to persistence structures and serialization logic |
| src/app/runtime.zig | Implemented onboarding message display logic with ANSI color codes |
| docs/configuration.md | Documented the new onboarding_shown persistence field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| stream.nextSlice(onboarding_msg) catch |err| { | ||
| log.warn("Failed to display onboarding message: {}", .{err}); | ||
| }; | ||
| sessions[0].markDirty(); | ||
| } | ||
| persistence.onboarding_shown = true; | ||
| persistence.save(allocator) catch |err| { | ||
| log.warn("Failed to save persistence after onboarding: {}", .{err}); | ||
| }; |
Copilot
AI
Jan 27, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error handling uses a catch block with a warning log, but then continues to set onboarding_shown = true even if the message failed to display. This means users who encounter this error will never see the onboarding message. Consider only setting the flag to true if the message is successfully displayed, or handle the error differently.
| stream.nextSlice(onboarding_msg) catch |err| { | |
| log.warn("Failed to display onboarding message: {}", .{err}); | |
| }; | |
| sessions[0].markDirty(); | |
| } | |
| persistence.onboarding_shown = true; | |
| persistence.save(allocator) catch |err| { | |
| log.warn("Failed to save persistence after onboarding: {}", .{err}); | |
| }; | |
| if (stream.nextSlice(onboarding_msg)) |_| { | |
| sessions[0].markDirty(); | |
| persistence.onboarding_shown = true; | |
| persistence.save(allocator) catch |err| { | |
| log.warn("Failed to save persistence after onboarding: {}", .{err}); | |
| }; | |
| } else |err| { | |
| log.warn("Failed to display onboarding message: {}", .{err}); | |
| } | |
| } |
Display a brief welcome message in grey text on first launch, explaining:
The message is shown once and tracked via onboarding_shown in persistence.toml.
https://claude.ai/code/session_013AMHvCsisuoq8T8BroZKs4