refactor(proxy): use context cancellation for tunnel tracking#65
Open
LaurenceJJones wants to merge 5 commits intodevfrom
Open
refactor(proxy): use context cancellation for tunnel tracking#65LaurenceJJones wants to merge 5 commits intodevfrom
LaurenceJJones wants to merge 5 commits intodevfrom
Conversation
- Replace []net.Conn slice with context + atomic counter in activeTunnel - Use errgroup.WithContext for pipe() to handle goroutine lifecycle - Use context.AfterFunc to close connections on cancellation - Fix race condition by comparing tunnel pointers instead of map lookup - UpdateLocalSNIs now cancels tunnel context instead of iterating conns This eliminates O(n) connection removal, prevents goroutine leaks, and provides cleaner cancellation semantics.
Remove atomic counter in favor of simple int protected by mutex. Eliminates race condition complexity and recheck logic.
Add pointer check before delete to handle race where UpdateLocalSNIs removes our tunnel and a new one is created for the same hostname.
LaurenceJJones
requested review from
miloschwartz and
oschwartz10612
as code owners
LaurenceJJones
force-pushed
the
proxy-context-tunnel-tracking
branch
from
317c304 to
390b401
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
This eliminates O(n) connection removal, prevents goroutine leaks, and provides cleaner cancellation semantics.
How to test?
Internal proxy usage.