Conversation
Refactoring the CLI to use `WithLogger` should fix a bug with the logger not being flushed correctly in the presence of exceptions, and error logging being lost.
The correct glob is `us-east-1/**/*.yaml`, not `us-east-1**/*.yaml`.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Newer aeson seems to order differently. We don't have any real need to be robust to that, so let's just fix it to match what it is now.
|
oh nice I think I was running into the log flushing thing myself |
derelbenkoenig
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(deps): update resolver and Blammo
67cc1f5
Refactoring the CLI to use
WithLoggershould fix a bug with the loggernot being flushed correctly in the presence of exceptions, and error
logging being lost.
fix: correct glob in finding specs
f4970e9
The correct glob is
us-east-1/**/*.yaml, notus-east-1**/*.yaml.