fix: order component layers in the graph#42
Merged
Mohammad-Tayyab-Frequenz merged 2 commits intofrequenz-floss:v0.x.xfrom Jan 21, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the ordering of component layers in graph visualizations by introducing a new ordering algorithm that ensures children of earlier parents are positioned above children of later parents, improving visual readability.
Changes:
- Added
_order_layersmethod to order nodes within each layer based on parent positions - Modified
compute_layoutto use the new ordering method before building positions - Updated
_build_positionsto use pre-ordered nodes instead of sorting internally
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/frequenz/gridpool/cli/_render_graph.py | Implements new _order_layers method and integrates it into the layout computation pipeline; removes internal sorting from _build_positions |
| tests/test_render_graph.py | Updates existing test to reflect pre-ordered node input; adds new integration test to verify children maintain parent ordering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cwasicki
previously approved these changes
Jan 21, 2026
Signed-off-by: Mohammad Tayyab <Mohammad.Tayyab@neustrom.de>
Signed-off-by: Mohammad Tayyab <Mohammad.Tayyab@neustrom.de>
702f501 to
d791fe1
Compare
cwasicki
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the ordering of component layers in graph visualizations by introducing a new ordering algorithm that ensures children of earlier parents are positioned above children of later parents, improving visual readability.
Changes: