[co-maintainer] Expose ofAsyncEnum/toAsyncEnum on netstandard2.0#214
Closed
github-actions[bot] wants to merge 2 commits intomainfrom
Closed
[co-maintainer] Expose ofAsyncEnum/toAsyncEnum on netstandard2.0#214github-actions[bot] wants to merge 2 commits intomainfrom
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
The .fsi signature file was gating ofAsyncEnum, toAsyncEnum, and ofIQueryable behind NETSTANDARD2_1 || NETCOREAPP3_0, while the .fs implementation already guarded them with NETSTANDARD || NET (which includes netstandard2.0). Since the project already depends on Microsoft.Bcl.AsyncInterfaces which provides IAsyncEnumerable<T> for netstandard2.0, aligning the .fsi guard makes these functions available on that target framework. Closes #173 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Closing as tests were not run. Let's try again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173Root cause
The
.fsisignature file hadofAsyncEnum,toAsyncEnum, andofIQueryablegated behind#if (NETSTANDARD2_1 || NETCOREAPP3_0), but the.fsimplementation already guarded them with#if (NETSTANDARD || NET)— which includesnetstandard2.0. Because the.fsicontrols what's visible in the public API, these functions were invisible onnetstandard2.0even though the implementation was compiled for that target.Fix
One-line change to
AsyncSeq.fsi: replacewith
This aligns the signature with the implementation.
Why it's safe
The project already takes a dependency on
Microsoft.Bcl.AsyncInterfaces(v5.0), which providesSystem.Collections.Generic.IAsyncEnumerable(T)fornetstandard2.0. So the BCL type is available and no new dependencies are needed.Trade-offs
None identified. The change is purely additive — it exposes an already-compiled API surface to an additional target framework.
Warning
The following domains were blocked by the firewall during workflow execution:
api.nuget.orgdc.services.visualstudio.com