Conversation
Widen the parameter type of AsyncSeq.mergeAll from 'AsyncSeq<'T> list' to 'seq<AsyncSeq<'T>>'. This is backward-compatible since list implements seq in F#, but also allows callers to pass arrays, other collections, or lazy sequences without needing an explicit conversion. The implementation materialises the seq to an array immediately since random-access (indexed look-up) and Length are needed internally. Closes #165 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 task
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by the repository's automated AI maintenance assistant.
Closes #165Summary
Widens the parameter type of
AsyncSeq.mergeAllfromAsyncSeq<'T> listtoseq(AsyncSeq<'T)>. This is a backward-compatible change sincelistimplementsseqin F#.This allows callers to pass arrays (e.g. results of
Async.Parallel), other collection types, or anyseq<_>without needing an explicit conversion to list.Changes
AsyncSeq.fs: Changed parameter type toseq(AsyncSeq<'T)>and addedlet ss = Seq.toArray ssat the start of the function body (needed since the implementation uses indexed access and.Lengthinternally).AsyncSeq.fsi: Updated signature to match.Test Status
dotnet build -c Debug)dotnet build -c Release)dotnet test -c Debug) — 182/182dotnet test -c Release) — 182/182