Fix Fable compatibility: guard getIterator obsolete attribute and complete #if FABLE_COMPILER cleanup#233
Merged
dsyme merged 3 commits intorepo-assist/v4-bcl-iasyncenumerable-migration-3b81040f29c8a5a6from Feb 22, 2026
Conversation
4 tasks
Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>
Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update AsyncSeq for Fable compatibility in migration
Fix Fable compatibility: guard Feb 22, 2026
getIterator obsolete attribute and complete #if FABLE_COMPILER cleanup
6 tasks
51f5b85
into
repo-assist/v4-bcl-iasyncenumerable-migration-3b81040f29c8a5a6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses remaining Fable build errors from the AsyncSeq v4
IAsyncEnumerable<'T>migration and cleans up[<Obsolete>]attribute handling for Fable vs .NET builds.Fable build errors (fixed in previous sub-PR, now merged)
ValueTask<T>unavailable in Fable — guardedAsyncSeqImpl<'T>'sIAsyncEnumeratorimplementation with#if !FABLE_COMPILERIAsyncEnumerable<_>.GetEnumeratornot found — for Fable,AsyncSeq<'T>is now defined as an interface with a publicGetEnumerator()returningIAsyncSeqEnumerator<'T>, avoiding BCL types unavailable in Fable[<Obsolete>]attribute cleanupgetIteratorinAsyncSeq.fsiwas unconditionally marked[<System.Obsolete("Use .GetEnumerator directly")>], but the message only makes sense for Fable (whereGetEnumerator()is a public interface method onAsyncSeq<'T>). In .NET builds,GetEnumerator()is an internal extension method not exposed in.fsi, making the guidance incorrect.Guard the attribute:
ofAsyncEnum/toAsyncEnumare already marked[<Obsolete>]and correctly excluded from Fable via#if !FABLE_COMPILER(they referenceIAsyncEnumerable<'T>which doesn't exist in Fable).🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.