Skip to content

Comments

[Repo Assist] Add tests for yield! list<'T> in asyncSeq computation expression#240

Merged
dsyme merged 1 commit intomainfrom
repo-assist/improve-test-yield-list-ffdcb1c01482d16e
Feb 23, 2026
Merged

[Repo Assist] Add tests for yield! list<'T> in asyncSeq computation expression#240
dsyme merged 1 commit intomainfrom
repo-assist/improve-test-yield-list-ffdcb1c01482d16e

Conversation

@github-actions
Copy link
Contributor

🤖 This PR was created by Repo Assist, an automated AI assistant.


Summary

The asyncSeq computation expression has a YieldFrom (s:seq<'T>) overload added in PR #236. Since F# list<'T> implements IEnumerable<'T> (seq<'T>), yield! someList compiles and runs via that same overload — but this was untested.

This PR adds two tests to make the implicit contract explicit and protect against future regressions:

  1. asyncSeq yield! list works — standalone yield! items where items : int list
  2. asyncSeq yield! list combines with other yieldsyield! items interleaved with explicit yield expressions

Test Status

✅ All 194 tests pass (dotnet test). The 2 new tests both pass on the first attempt, confirming that yield! list already works correctly via the seq<'T> overload.

Generated by Repo Assist

To install this workflow, run gh aw add githubnext/agentics/workflows/repo-assist.md@ee50a3b7d1d3eb4a8c409ac9409fd61c9a66b0f5. View source at https://github.com/githubnext/agentics/tree/ee50a3b7d1d3eb4a8c409ac9409fd61c9a66b0f5/workflows/repo-assist.md.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Contributor Author

✅ Pull request created: #240

@dsyme dsyme marked this pull request as ready for review February 22, 2026 21:52
@dsyme dsyme closed this Feb 22, 2026
@dsyme dsyme reopened this Feb 22, 2026
@dsyme dsyme merged commit 97c0e3d into main Feb 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant