Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
✅ Pull request created: #240 |
dsyme
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
The
asyncSeqcomputation expression has aYieldFrom (s:seq<'T>)overload added in PR #236. Since F#list<'T>implementsIEnumerable<'T>(seq<'T>),yield! someListcompiles and runs via that same overload — but this was untested.This PR adds two tests to make the implicit contract explicit and protect against future regressions:
asyncSeq yield! list works— standaloneyield! itemswhereitems : int listasyncSeq yield! list combines with other yields—yield! itemsinterleaved with explicityieldexpressionsTest Status
✅ All 194 tests pass (
dotnet test). The 2 new tests both pass on the first attempt, confirming thatyield! listalready works correctly via theseq<'T>overload.