Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BaseLogger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ export function createLoggerEnvironment(): LoggerEnvironment {
if (typeof value === "function") {
return result;
}
result.push(String(value));
result.push(stringifyFallback(value));
return result;
}, [])
.join(", ");
Expand Down
44 changes: 44 additions & 0 deletions tests/27_advanced_errors.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Logger } from "../src/index.js";
import { getConsoleLogStripped, mockConsoleLog } from "./helper.js";

class HttpError extends Error {
status: number;
Expand Down Expand Up @@ -123,4 +124,47 @@ describe("Advanced error handling", () => {
const rangeErr = logger.info(new RangeError("out of range"));
expect(rangeErr?.name).toBe("RangeError");
});

describe("pretty error message with non-primitive property values", () => {
beforeEach(() => {
mockConsoleLog(true, false);
});

test("error property with null-prototype object does not throw", () => {
const logger = new Logger({ type: "pretty", stylePrettyLogs: false });
const err = new Error("boom") as Error & { details: unknown };
// Object.create(null) has no prototype, so String(value) throws
// "Cannot convert object to primitive value".
err.details = Object.create(null);

expect(() => logger.error(err)).not.toThrow();
expect(getConsoleLogStripped()).toContain("boom");
});

test("error property with throwing toString does not throw", () => {
const logger = new Logger({ type: "pretty", stylePrettyLogs: false });
const err = new Error("kaboom") as Error & { payload: unknown };
err.payload = {
toString() {
throw new Error("toString blew up");
},
};

expect(() => logger.error(err)).not.toThrow();
expect(getConsoleLogStripped()).toContain("kaboom");
});

test("error property with Symbol.toPrimitive returning object does not throw", () => {
const logger = new Logger({ type: "pretty", stylePrettyLogs: false });
const err = new Error("oops") as Error & { weird: unknown };
err.weird = {
[Symbol.toPrimitive]() {
return {} as unknown as string;
},
};

expect(() => logger.error(err)).not.toThrow();
expect(getConsoleLogStripped()).toContain("oops");
});
});
});