Implement resume support for video downloads#3220
Open
kikoso wants to merge 1 commit intofuto-org:masterfrom
Open
Implement resume support for video downloads#3220kikoso wants to merge 1 commit intofuto-org:masterfrom
kikoso wants to merge 1 commit intofuto-org:masterfrom
Conversation
|
Please sign our contributor license agreement at https://cla.futo.org |
|
Please sign our contributor license agreement at https://cla.futo.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to resume interrupted or cancelled video downloads instead of forcing them to start from scratch. Previously, whenever a download failed or was manually stopped, the app would automatically delete the remaining partial video and audio files from the disk. With these changes, partial files are now retained on the filesystem, and the byte-range download logic has been updated to check the existing file length and seamlessly append new data using the correct initial read offset.
Under the hood,
VideoDownloadnow utilizes an appendingFileOutputStreamwhen resuming a byte-range download, allowing it to gracefully skip the chunks that have already been saved. Additionally, thecleanupDownloadsroutine inStateDownloadshas been patched to recognize actively downloading (or paused) files as "valid." This fix makes sure that the app's internal storage cleanup sweeps do not accidentally delete incomplete files before the user has a chance to resume their download.2026-03-30.13.47.56.mp4