ci: use github app for release-please permissions#396
Open
gustavkj wants to merge 1 commit intogagoar:masterfrom
Open
ci: use github app for release-please permissions#396gustavkj wants to merge 1 commit intogagoar:masterfrom
gustavkj wants to merge 1 commit intogagoar:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 7488811828
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 284 284
Branches 64 64
=========================================
Hits 284 284
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Owner
|
Thanks for the detailed steps. I will do this after we release these new functionalities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that we have an issue with the release PR made by
release-please. Since events triggered by the Github Actions bot won't trigger additional runs, the status checks aren't met as the workflows won't run.One way to fix this is to set up a Github App user for
release-pleaseto use, that way it is a different user and as such the workflows will trigger.If we choose this option, you need to create a Github App:
Codeowners-Generator Release Bot.Contents: writeandPull-requests: write, which are the permissions thatrelease-pleaseneeds.RELEASE_PLEASE_PRIVATE_KEYand set it to the content of the newly generated private key. Create another secret namedRELEASE_PLEASE_APP_IDand set it to the App ID.