Skip to content

Update the GAP banner to reflect the new GAP logo#6357

Merged
fingolfin merged 2 commits into
gap-system:masterfrom
mtorpey:cool-gap-logo-nocolor
May 23, 2026
Merged

Update the GAP banner to reflect the new GAP logo#6357
fingolfin merged 2 commits into
gap-system:masterfrom
mtorpey:cool-gap-logo-nocolor

Conversation

@mtorpey
Copy link
Copy Markdown
Contributor

@mtorpey mtorpey commented Apr 30, 2026

This PR modifies the GAP banner on startup to show a rendering of the new logo. If the terminal encoding is UTF-8 it does this with nice Unicode dot characters, but falls back to letter o symbols otherwise.

This is an alternative to #6224 which supports colour but has some line-wrapping issues.

@mtorpey mtorpey requested a review from fingolfin April 30, 2026 15:27
@fingolfin
Copy link
Copy Markdown
Member

Some "screenshots" to visualize

Current:

image

With this PR:

image

With this PR and no UTF-8 output available:

image

With this PR, modified for "compact" look:

image

With this PR, modified for "compact" look, no UTF-8:

image

@fingolfin
Copy link
Copy Markdown
Member

Just to say, while "thumbs up" to this PR are nice, what we really need is a decision whether to merge this; and if so, whether to use the compact or the "non-compact" version; and of course, approvals of the PR.

Comment thread lib/init.g Outdated
Co-authored-by: Max Horn <max@quendi.de>
@ChrisJefferson
Copy link
Copy Markdown
Contributor

I vote this PR, compact.

@james-d-mitchell
Copy link
Copy Markdown
Contributor

I vote for the original logo or the compact black white one, I'd be happy with either

@stertooy
Copy link
Copy Markdown
Contributor

I'll also vote for the compact version of this PR.

@fingolfin
Copy link
Copy Markdown
Member

@james-d-mitchell by "the black white one", do you mean the non-UTF8 one? I.e. the one in the last picture?

@olexandr-konovalov
Copy link
Copy Markdown
Member

+1 for this PR, compact

@james-d-mitchell
Copy link
Copy Markdown
Contributor

@james-d-mitchell by "the black white one", do you mean the non-UTF8 one? I.e. the one in the last picture?

Yes sorry the same one as @ChrisJefferson

@fingolfin
Copy link
Copy Markdown
Member

@james-d-mitchell now I am even more confused, as Chris was just voting for "compact": do you vote for the compact layout (which appears as in picture 4 in most terminals but falls back to image 5 if the terminal does not report support for UTF8). Or do you prefer always showing the fallback?

@fingolfin
Copy link
Copy Markdown
Member

I guess we should just make 5 comments, one for each picture; and people can thumbs up/down each (or not vote, for three levels of support)

can't do it myself right now though, need to get the kids to finally sleep

@olexandr-konovalov
Copy link
Copy Markdown
Member

I will do this now. Please vote using 5 separate comments below.

@olexandr-konovalov
Copy link
Copy Markdown
Member

olexandr-konovalov commented May 21, 2026

Option 1: Current:

image

@olexandr-konovalov
Copy link
Copy Markdown
Member

olexandr-konovalov commented May 21, 2026

Option 2: With this PR:

image

@olexandr-konovalov
Copy link
Copy Markdown
Member

olexandr-konovalov commented May 21, 2026

Option 3: With this PR and no UTF-8 output available:

image

@olexandr-konovalov
Copy link
Copy Markdown
Member

olexandr-konovalov commented May 21, 2026

Option 4: With this PR, modified for "compact" look:

image

@olexandr-konovalov
Copy link
Copy Markdown
Member

olexandr-konovalov commented May 21, 2026

Option 5: With this PR, modified for "compact" look, no UTF-8:

image

@james-d-mitchell
Copy link
Copy Markdown
Contributor

@james-d-mitchell now I am even more confused, as Chris was just voting for "compact": do you vote for the compact layout (which appears as in picture 4 in most terminals but falls back to image 5 if the terminal does not report support for UTF8). Or do you prefer always showing the fallback?

Sorry for being confusing I've thumbs up the one I meant now, hazards of commenting from my phone

Copy link
Copy Markdown
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the compact version, which a lot of people seem to like, so going for that now.

@fingolfin fingolfin merged commit 8439e2a into gap-system:master May 23, 2026
28 of 30 checks passed
fingolfin added a commit that referenced this pull request May 23, 2026
@fingolfin
Copy link
Copy Markdown
Member

Argh, I just realized this PR had a mixe version. Fixed this on master with a direct push (naughty, I know, but we already had an agreement so I didn't want to go through the full dance again for a trivial change like that)

@mtorpey mtorpey deleted the cool-gap-logo-nocolor branch May 25, 2026 13:39
@fingolfin fingolfin changed the title Add new logo to banner (B&W) Update the GAP banner to reflect the new GAP logo May 26, 2026
@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants