kernel: improve ErrorReturnVoid break-loop message#6416
Conversation
fingolfin
added
topic: kernel
release notes: not needed
fingolfin
force-pushed
the
codex/consistent-ErrorReturn-guidance-message
branch
from
425503d to
269e028
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6416 +/- ##
=======================================
Coverage 78.87% 78.87%
=======================================
Files 685 685
Lines 293543 293549 +6
Branches 8679 8672 -7
=======================================
+ Hits 231519 231530 +11
+ Misses 60215 60212 -3
+ Partials 1809 1807 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fingolfin
force-pushed
the
codex/consistent-ErrorReturn-guidance-message
branch
from
269e028 to
188d8fd
Compare
| @ *stdin*:1 | ||
| ... at *stdin*:4 | ||
| you may 'return;' | ||
| you can 'return;' |
There was a problem hiding this comment.
| you can 'return;' | |
| you can 'return;' to continue |
Shouldn't it be like this in all occurrences in this file?
There was a problem hiding this comment.
Good catch, thanks. I'll double check when I am back at a computer.
There was a problem hiding this comment.
In fact it should have been two lines:
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
I've updated the text now.
| ... at *stdin*:3 | ||
| you may 'return;' | ||
| you can 'quit;' to quit to outer loop, or | ||
| you can 'return;' to continue |
There was a problem hiding this comment.
Staring at this again, I wonder if we should insert a verb like "enter" or "type", like
| you can 'return;' to continue | |
| you can enter 'return;' to continue |
... and in general make its phrasing more consistent. AI-assisted: OpenAI Codex prepared this code change. Co-authored-by: Codex <codex@openai.com>
fingolfin
force-pushed
the
codex/consistent-ErrorReturn-guidance-message
branch
from
188d8fd to
8e98ca4
Compare
|
Ugh, looking closer for more parts to be adjusted, I discovered parts of the documentation that had been outdated for years. |
| gap> f2( 4 ); | ||
| value: 4 | ||
| Error, Function Calls: <func> must return a value | ||
| Stack trace: |
There was a problem hiding this comment.
Hrm, I added this message (or rather asked the AI to add it, but in any case, my fault); but now question that. I'll open a separate PR to explore removing it again.
3 participants
... and in general make its phrasing more consistent.
AI-assisted: OpenAI Codex prepared this code change.
Resolves #6272