Skip to content

kernel: refactor FuncPRINT_CURRENT_STATEMENT#6424

Open
fingolfin wants to merge 1 commit into
masterfrom
codex/refactor-FuncPRINT_CURRENT_STATEMENT
Open

kernel: refactor FuncPRINT_CURRENT_STATEMENT#6424
fingolfin wants to merge 1 commit into
masterfrom
codex/refactor-FuncPRINT_CURRENT_STATEMENT

Conversation

@fingolfin
Copy link
Copy Markdown
Member

Move part of the code from the kernel to the library. This will make future improvements easier.

Co-authored-by: Codex codex@openai.com


(Specifically, I have two follow-up PRs prepared that will further improve the stacktrace printing; it is easier to do that if as much of the code as possible is written in GAP.)

@fingolfin fingolfin added topic: kernel release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jun 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

❌ Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.86%. Comparing base (74a43d6) to head (11f06b4).

Files with missing lines Patch % Lines
lib/error.g 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6424      +/-   ##
==========================================
- Coverage   78.86%   78.86%   -0.01%     
==========================================
  Files         685      685              
  Lines      293550   293547       -3     
  Branches     8672     8647      -25     
==========================================
- Hits       231515   231508       -7     
- Misses      60225    60230       +5     
+ Partials     1810     1809       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lgoettgens
Copy link
Copy Markdown
Member

I can have a look at this. Just request a review once CI passes

@fingolfin fingolfin force-pushed the codex/refactor-FuncPRINT_CURRENT_STATEMENT branch 2 times, most recently from 51a4cec to 40ce397 Compare June 5, 2026 21:35
Move part of the code from the kernel to the library.
This will make future improvements easier.

Co-authored-by: Codex <codex@openai.com>
@fingolfin fingolfin force-pushed the codex/refactor-FuncPRINT_CURRENT_STATEMENT branch from 40ce397 to 11f06b4 Compare June 5, 2026 21:38
@fingolfin
Copy link
Copy Markdown
Member Author

@lgoettgens thanks, I fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants