fix: Always return empty releaseNotes endpoint response#214
Merged
Conversation
sh4sm
force-pushed
the
fix/empty-release-page-response
branch
from
f952ecf to
445d129
Compare
Quick fix now to avoid issues with too large release pages for the Github API. Also the previous response required a manual clean up anyway, so avoid publishing these false-positives, which could be picked up by external parties like VAS.
sh4sm
force-pushed
the
fix/empty-release-page-response
branch
from
445d129 to
8af2a46
Compare
moritzkirchnersap
approved these changes
Apr 29, 2026
Contributor
moritzkirchnersap
left a comment
moritzkirchnersap
left a comment
There was a problem hiding this comment.
Please add test coverage to reach at least ~95% diff coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Quick fix now to avoid issues with too large release pages for the Github API. Also the previous response required a manual clean up anyway, so avoid publishing these false-positives, which could be picked up by external parties like VAS.