fix(learnings): preserve current entries in cross-project search#1619
Open
jbetala7 wants to merge 1 commit into
Open
fix(learnings): preserve current entries in cross-project search#1619jbetala7 wants to merge 1 commit into
jbetala7 wants to merge 1 commit into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1618
Summary
Root cause
gstack-learnings-search --cross-projectinferred cross-project rows with!line.includes(slug). Current-project learnings do not normally include the project slug in their JSON body, so observed/inferred current learnings withtrusted:falsewere treated as foreign and dropped.Verification
bun test test/gstack-learnings-search.test.tsbun test test/learnings.test.ts test/gstack-learnings-search.test.ts--cross-project --query currentnow prints the current observed learning, while--query foreignonly prints the trusted user-stated foreign learninggit diff --check origin/main...HEADgit merge-tree --write-tree HEAD origin/mainCollision check
Searched open issues/PRs for
cross-project learnings,gstack-learnings-search cross-project trusted,current project learnings --cross-project,cross-project trust gate learnings,gstack-learnings-search --cross-project,bin/gstack-learnings-search, and issue#1618.Open PR #940 touches
bin/gstack-learnings-search, but it retains the sameline.includes(slug)cross-project classification and is about legacy schema normalization, so it does not cover this bug.